Path: ...!feeds.phibee-telecom.net!news.mixmin.net!eternal-september.org!feeder3.eternal-september.org!news.eternal-september.org!.POSTED!not-for-mail From: Ben Bacarisse Newsgroups: comp.lang.c Subject: Re: Fixing a sample from K&R book using cake static analyser Date: Tue, 25 Jun 2024 01:42:14 +0100 Organization: A noiseless patient Spider Lines: 22 Message-ID: <871q4lontl.fsf@bsb.me.uk> References: <20240623034624.135@kylheku.com> <87wmmfq4if.fsf@bsb.me.uk> <20240624012527.8bbe16b96f5bfca10feadb5c@gmail.moc> <87zfrbnsvv.fsf@bsb.me.uk> <87ikxyobls.fsf@bsb.me.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Date: Tue, 25 Jun 2024 02:42:15 +0200 (CEST) Injection-Info: dont-email.me; posting-host="b2e0149f9e88712508ba5999d7ddf609"; logging-data="1265544"; mail-complaints-to="abuse@eternal-september.org"; posting-account="U2FsdGVkX1/ufi/wMJDN4l1eOoElP+Fs3IuNlirK5H8=" User-Agent: Gnus/5.13 (Gnus v5.13) Cancel-Lock: sha1:UDQ8q5bi94i6y2krGpQchbcLNS0= sha1:gdRvS3BWUGYuD9BoEjRxhzdh+wY= X-BSB-Auth: 1.41bfbcaf1fc08fa98294.20240625014214BST.871q4lontl.fsf@bsb.me.uk Bytes: 1987 Lawrence D'Oliveiro writes: > On Mon, 24 Jun 2024 11:53:51 +0100, Ben Bacarisse wrote: > >> Lawrence D'Oliveiro writes: >> >>> Too many different paths in the control flow, though. I think it’s a >>> good idea to minimize that. >> >> Your non-solution has more. > > My solution only has one major flow of control: in the top and out the > bottom. Everything else is error checks, and it is quite obvious where > they all go--through the same cleanup path. Oh I see. Mine has only one major flow of control. All the others are error checks. You are not a serious poster. -- Ben.