Path: ...!eternal-september.org!feeder3.eternal-september.org!news.eternal-september.org!eternal-september.org!.POSTED!not-for-mail
From: Ben Bacarisse <ben@bsb.me.uk>
Newsgroups: comp.lang.c
Subject: Re: So You Think You Can Const?
Date: Thu, 09 Jan 2025 01:09:20 +0000
Organization: A noiseless patient Spider
Lines: 41
Message-ID: <87ldvk4wu7.fsf@bsb.me.uk>
References: <vljvh3$27msl$1@dont-email.me> <20250107130809.661@kylheku.com>
	<vlm0hf$2dkpd$1@dont-email.me> <87a5c15ob0.fsf@bsb.me.uk>
	<vlm7o4$2dkpd$4@dont-email.me> <vlm8r6$2dkpd$5@dont-email.me>
MIME-Version: 1.0
Content-Type: text/plain
Injection-Date: Thu, 09 Jan 2025 02:09:20 +0100 (CET)
Injection-Info: dont-email.me; posting-host="903c6fa9911b65ebad208378657cc749";
	logging-data="3193893"; mail-complaints-to="abuse@eternal-september.org";	posting-account="U2FsdGVkX18gkQFHJuMvpRo0H4mP0e8T9QPK+HJ73pw="
User-Agent: Gnus/5.13 (Gnus v5.13)
Cancel-Lock: sha1:91ry83WesT4l0Yk0yM7WAdWmN00=
	sha1:Ayi2lIVQNS0DNq9g2Cd6sbY3xDc=
X-BSB-Auth: 1.f352f0569c598776c58e.20250109010920GMT.87ldvk4wu7.fsf@bsb.me.uk
Bytes: 1991

Julio Di Egidio <julio@diegidio.name> writes:

> static AvlTree_t const *AvlTree_node(
>     void const *pk, AvlTree_t const *pL, AvlTree_t const *pR
> ) {
>     AvlTree_t *pT;
>
>     pT = malloc(sizeof(AvlTree_t));
>
>     if (!pT) {
>         return NULL;
>     }
>
>     pT->pk = pk;
>     pT->pL = pL;
>     pT->pR = pR;
>
>     return pT;
> }

Just on a side issue, I prefer to make tests like this positive so I'd
write:

 static AvlTree_t const *AvlTree_node(
     void const *pk, AvlTree_t const *pL, AvlTree_t const *pR
 ) {
     AvlTree_t *pT = malloc(*pT);
 
     if (pT) {
         pT->pk = pk;
         pT->pL = pL;
         pT->pR = pR;
     }
     return pT;
 }

I'm not going to "make a case" for this (though I will if you want!) --
I just think it helps to see lots of different styles.

-- 
Ben.