Path: ...!weretis.net!feeder8.news.weretis.net!eternal-september.org!feeder3.eternal-september.org!news.eternal-september.org!.POSTED!not-for-mail
From: Ben Bacarisse <ben.usenet@bsb.me.uk>
Newsgroups: comp.lang.c
Subject: Re: filling area by color atack safety
Date: Sun, 17 Mar 2024 10:31:18 +0000
Organization: A noiseless patient Spider
Lines: 31
Message-ID: <87r0g9jgjt.fsf@bsb.me.uk>
References: <ut3669$21eur$1@i2pn2.org> <ut4020$2s8ov$1@dont-email.me>
	<ut4b09$2uhpm$1@dont-email.me> <BulJN.144026$CYpe.133853@fx40.iad>
MIME-Version: 1.0
Content-Type: text/plain
Injection-Info: dont-email.me; posting-host="664dca1fae3f1391a07afac504c68131";
	logging-data="3659162"; mail-complaints-to="abuse@eternal-september.org";	posting-account="U2FsdGVkX189+FKs9lnbo5umiOubKJxdCR5+nMTmJpw="
User-Agent: Gnus/5.13 (Gnus v5.13)
Cancel-Lock: sha1:MMKWcHBp61mL8fy3cst00i2yJGI=
	sha1:ndDit9lNC2CMnKKSj0AfQTjHVx0=
X-BSB-Auth: 1.aeb2745325f2ec05fa32.20240317103118GMT.87r0g9jgjt.fsf@bsb.me.uk
Bytes: 2212

scott@slp53.sl.home (Scott Lurndal) writes:

> David Brown <david.brown@hesbynett.no> writes:
>>On 16/03/2024 12:33, Malcolm McLean wrote:
>
>>> And here's some code I wrote a while ago. Use that as a pattern. But not 
>>> sure how well it works. Haven't used it for a long time.
>>> 
>>> https://github.com/MalcolmMcLean/binaryimagelibrary/blob/master/drawbinary.c
>>> 
>>
>>Your implementation is a mess, /vastly/ more difficult to prove correct 
>
> Malcolm can't even spell 'integer' correctly in that code blob :-).

As someone with dyslexia I have never liked mocking remarks about
spelling errors.  Using "even" suggests that a superficial issue hints
at deeper problems.  This is rarely the case.

However, I /would/ urge Malcolm to correct the spelling if Bresenham
since the intent was clearly to credit the discoverer.  Also,
misspellings don't play well with library databases.

> Certainly the intent of Fir's algorithm is easily discerned from
> his code.   I can't say that about Malcolms.

I have some reservations about the code, but he posted a link so there
is no indication that he wants a review of it.

-- 
Ben.