Path: ...!weretis.net!feeder9.news.weretis.net!news.quux.org!eternal-september.org!feeder3.eternal-september.org!news.eternal-september.org!eternal-september.org!.POSTED!not-for-mail
From: Ben Bacarisse <ben@bsb.me.uk>
Newsgroups: comp.lang.c
Subject: Re: So You Think You Can Const?
Date: Fri, 10 Jan 2025 01:04:01 +0000
Organization: A noiseless patient Spider
Lines: 66
Message-ID: <87zfjz32f2.fsf@bsb.me.uk>
References: <vljvh3$27msl$1@dont-email.me> <20250107130809.661@kylheku.com>
	<vlm0hf$2dkpd$1@dont-email.me> <87a5c15ob0.fsf@bsb.me.uk>
	<vlm7o4$2dkpd$4@dont-email.me> <vlm8r6$2dkpd$5@dont-email.me>
	<87ldvk4wu7.fsf@bsb.me.uk> <vlnrib$2dkpc$5@dont-email.me>
	<875xmn4lmy.fsf@bsb.me.uk> <vlpmkm$2dkpd$16@dont-email.me>
MIME-Version: 1.0
Content-Type: text/plain
Injection-Date: Fri, 10 Jan 2025 02:04:02 +0100 (CET)
Injection-Info: dont-email.me; posting-host="f1e4bab61ffdd6428ab3d41e59cd9948";
	logging-data="3810856"; mail-complaints-to="abuse@eternal-september.org";	posting-account="U2FsdGVkX18UQ+rDLpqorMS0Sfw5dyl7AxcBlaQ90zw="
User-Agent: Gnus/5.13 (Gnus v5.13)
Cancel-Lock: sha1:4182Mj4ACe+S1rHgxx1nM2lfXJw=
	sha1:/UftQGQTqRRcpAT6cEPYYOyQQ4U=
X-BSB-Auth: 1.775157506514fb159f9e.20250110010401GMT.87zfjz32f2.fsf@bsb.me.uk
Bytes: 3422

Julio Di Egidio <julio@diegidio.name> writes:

> On 10/01/2025 00:23, Ben Bacarisse wrote:
>> Julio Di Egidio <julio@diegidio.name> writes:
>> 
>>> On 09/01/2025 02:09, Ben Bacarisse wrote:
>>>> Julio Di Egidio <julio@diegidio.name> writes:
>>>>
>>>>> static AvlTree_t const *AvlTree_node(
>>>>>       void const *pk, AvlTree_t const *pL, AvlTree_t const *pR
>>>>> ) {
>>>>>       AvlTree_t *pT;
>>>>>
>>>>>       pT = malloc(sizeof(AvlTree_t));
>>>>>
>>>>>       if (!pT) {
>>>>>           return NULL;
>>>>>       }
>>>>>
>>>>>       pT->pk = pk;
>>>>>       pT->pL = pL;
>>>>>       pT->pR = pR;
>>>>>
>>>>>       return pT;
>>>>> }
>>>> Just on a side issue, I prefer to make tests like this positive so I'd
>>>> write:
>>>>    static AvlTree_t const *AvlTree_node(
>>>>        void const *pk, AvlTree_t const *pL, AvlTree_t const *pR
>>>>    ) {
>>>>        AvlTree_t *pT = malloc(*pT);
>>>>          if (pT) {
>>>>            pT->pk = pk;
>>>>            pT->pL = pL;
>>>>            pT->pR = pR;
>>>>        }
>>>>        return pT;
>>>>    }
>>>> I'm not going to "make a case" for this (though I will if you want!) --
>>>> I just think it helps to see lots of different styles.
>>>
>>> That is *more* error prone,
>> I would be happy for you to expand on why you say that.
>> 
>>> all the more so if it's not a 5 liner...
>
> There is no such thing as expanding 40 years of professional experience in
> software engineering and programming and doing it properly since day one:
> just think about that code and what I said for what it's worth, in
> particular I haven't mentioned 5 liners by chance, things are quite more
> complicated not in vitro.
>
> And please do not hold a grudge about that: it's not me who was trying to
> say how to write code... ;)

I was not trying to tell anyone how to write code.  You made a claim --
not even a qualified one, a categorical one -- the justification for
which I would have liked to know more about.

> HTH,

Not really, but no one is under any obligation here.  It's just a
discussion.

-- 
Ben.