Path: ...!news.mixmin.net!news2.arglkargh.de!news.karotte.org!fu-berlin.de!bofh.it!news.nic.it!robomod
From: Luca Boccassi <bluca@debian.org>
Newsgroups: linux.debian.bugs.dist,linux.debian.maint.boot
Subject: Bug#1039142: busybox: ships sysv-init script without systemd unit
Date: Tue, 14 Nov 2023 13:10:01 +0100
Message-ID: <HA0oV-5o04-7@gated-at.bofh.it>
References: <GKGIp-SUy-7@gated-at.bofh.it> <GKGIp-SUy-7@gated-at.bofh.it> <HzHmh-5bUF-1@gated-at.bofh.it> <GKGIp-SUy-7@gated-at.bofh.it> <HzHmh-5bUF-1@gated-at.bofh.it>
X-Mailbox-Line: From debian-bugs-dist-request@lists.debian.org  Tue Nov 14 12:00:14 2023
Old-Return-Path: <debbugs@buxtehude.debian.org>
X-Spam-Flag: NO
X-Spam-Score: -2.61
Reply-To: Luca Boccassi <bluca@debian.org>, 1039142@bugs.debian.org
Resent-To: debian-bugs-dist@lists.debian.org
Resent-Cc: Debian Install System Team <debian-boot@lists.debian.org>
X-Debian-Pr-Message: followup 1039142
X-Debian-Pr-Package: busybox
X-Debian-Pr-Keywords: help
X-Debian-Pr-Source: busybox
X-Gm-Message-State: AOJu0YzlTw4bHCSTK4RjhwMaWVrizh3Gt9t+8Cec+jEsN1u7lww6qQep
	QdvNrk+lm7ihVOLYBB2gls50WeH5DA+3pw==
X-Google-SMTP-Source: AGHT+IFh//jPgZWvhTzlkiefZVpk1kigwzQ6YEufLyhs0g+/TNGqITXUQsPKh5rnOPZWHxhZgrvSVw==
X-Received: by 2002:a5d:6c61:0:b0:32d:8819:4620 with SMTP id r1-20020a5d6c61000000b0032d88194620mr7106447wrz.14.1699963006856;
        Tue, 14 Nov 2023 03:56:46 -0800 (PST)
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="=-bZjRJwhfIgMEuJLEMtQ0"
User-Agent: Evolution 3.46.4-2 
MIME-Version: 1.0
X-Debian-Message: from BTS
X-Mailing-List: <debian-bugs-dist@lists.debian.org> archive/latest/1805934
List-ID: <debian-bugs-dist.lists.debian.org>
List-URL: <https://lists.debian.org/debian-bugs-dist/>
Approved: robomod@news.nic.it
Lines: 97
Organization: linux.* mail to news gateway
Sender: robomod@news.nic.it
X-Original-Cc: mjt@tls.msk.ru
X-Original-Date: Tue, 14 Nov 2023 11:56:44 +0000
X-Original-Message-ID: <53e1570fd95b9729ecb7853ef6c562c46f070674.camel@debian.org>
X-Original-References: <befdeaaf70e11a2c845c3674f275b672.luca.boccassi@gmail.com> <befdeaaf70e11a2c845c3674f275b672.luca.boccassi@gmail.com> <5390dc77-f2d9-46db-878a-5dc67ec7b906@tls.msk.ru> <befdeaaf70e11a2c845c3674f275b672.luca.boccassi@gmail.com> <5390dc77-f2d9-46db-878a-5dc67ec7b906@tls.msk.ru>
Bytes: 6273


--=-bZjRJwhfIgMEuJLEMtQ0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 13 Nov 2023 18:42:09 +0300 Michael Tokarev <mjt@tls.msk.ru>
wrote:
> Control: tag -1 + help
>=20
> On Sun, 25 Jun 2023 23:20:24 +0100 bluca@debian.org=C2=A0wrote:
> > Package: busybox
> > Severity: important
> > User: bluca@debian.org
> > Usertags: missing-systemd-service
> >=20
> > Dear Maintainer(s),
> >=20
> > busybox has been flagged by Lintian as shipping a sysv-init script
> > without a corresponding systemd unit file. The default init system
in
> > Debian is systemd, and so far this worked because a transitional
> > sysv-init-to-unit generator was shipped by systemd. This is in the
> > process of being deprecated and will be removed by the time Trixie
> > ships, so the remaining packages that ship init scripts without
> > systemd units will stop working.
> >=20
> > There are various advantages to using native units, for example the
> > legacy generator cannot tell the different between a oneshot
service
> > and a long running daemon. Also, sanboxing and security features
> > become available for services. For more information, consult the
> > systemd documentation:
> > https://www.freedesktop.org/software/systemd/man/systemd.unit.html
> >=20
> > You can find the Lintian warning here:
> >=20
> > https://lintian.debian.org/sources/busybox
>=20
> This site can't be found.=C2=A0 But it's ok.

Yeah things around Lintian publishing have changed since these bugs
have been filed

> So in current state, only udhcpd lacks systemd file.=C2=A0 So I tried to
> provide one.=C2=A0 The initscript for udhcpd checks for
UDHCPD_ENABLED=3Dyes/no
> in /etc/default/udhcpd and does nothing if it is not enabled, which
> is the default.=C2=A0 Since there's no way in systemd to check for that
> (well, there is, with ExecConditional, but it ugly at best), I
thought
> to ship udhcpd.service not enabled by default.=C2=A0 Except it doesn't
> work.
>=20
> With just dh_installsystemd --no-enable, it is still started.
> With dh_installsystemd --no-enable --no-start, it is started
> as well, - apparently because initscript is started.=C2=A0 Also,
> with --no-enable --no-start, it is not restarted on upgrades
> if enabled locally.
>=20
> After doing several iterations, I decided to abandon this attempt, -
> it just does not work, and I've no time to fight with the tools.
>=20
> If someone has a working recipe for all this madness, please
> share a patch for d/rules.
>=20
> Tagging with "help" for now.

Could you please share a branch or a patch with your attempt? What you
tried should work, but it's hard to say without looking at the
implementation in details.

--=20
Kind regards,
Luca Boccassi

--=-bZjRJwhfIgMEuJLEMtQ0
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEErCSqx93EIPGOymuRKGv37813JB4FAmVTYHwACgkQKGv37813
JB5x1A//aFQyl9ZwIYisYadraIbgB2O2UO6M+aCtgQZcTP28xemq3tN9mQ8V7UzW
fMRev1dUot0sRXfJgtFp8lQM2AEKMI5YsYg7MnVcwHn3QRn7QmSgjJ1bfqLV2gG/
XK69OaVXRZ/XT/Mwytf+MPDM5bwxbcV7wynQAfAa/Gc/JDb7H3HHLHi9xpyDyjKR
U1nTFe1uxtFGFU0TBMH8SG5099fNBjmNL95HIOxKVI3ScMPrPILi5t6xOW6jFD/O
zeRnSyzixdzrVfxWS/L8GtmbLKLiefA4UEOe+FcsowDh0UA12bXi9OBWw8R8Evkz
45pu6bhrTk5/54bA86CANFcDJ74tzq+QVOEvztD1tNgKLgHM4Nztt5SPvUvUjStV
vcsb+u3zRPUaA57n8pmbUyvYEws7HVnKYXPDWuNNFTn0XTVwTKyNSBP5VfuhWDd8
O3bk7FppKQXIWna7+PDXvXpNydHmHICqUTO+UhVricRq2zTyWYxTLrKpaJo1y/TH
3K2rPZyZPQm0GLGVWQvt3WPxYg7voacIS5k0Uo6o3wuEOt0YIHpDEwBrhjxVE7dl
bw+aCvQmCdYQGr3NGEdw5Q4gJEZns8MY18zXp9rdXEGr1sa/KvF1OICp3Y/B0Ooy
rIXMwR+0Jra5/CHpgJVQMbHvht1TAgwPDkveKHjPx5n/4eMuaXc=
=AkA/
-----END PGP SIGNATURE-----

--=-bZjRJwhfIgMEuJLEMtQ0--